Added the support for --image-name flag in the astro deploy command #1751
+125
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rujhan-arora-astronomer
requested review from
neel-astro,
jeremybeard and
kushalmalani
as code owners
rujhan-arora-astronomer
force-pushed
the
feature/6828
branch
from
1c17719 to
6b6f564
Compare
neel-astro
reviewed
Dec 6, 2024
Comment on lines
+438
to
+440
| if runtimeVersion == "" { | ||
| return ErrNoRuntimeVersionPassed | ||
| } |
There was a problem hiding this comment.
nit: do we need to validate that runtimeVersion is a valid semver and present in updates.astronomer.io? Or does the Houston API do that for us?
| if runtimeVersion == "" { | ||
| return ErrNoRuntimeVersionPassed | ||
| } | ||
| if imageName == "" { |
There was a problem hiding this comment.
nit: Should we validate that the image being passed is built using the same runtime version as the one being passed on as user input? Or does the Houston API do that for us?
Comment on lines
+444
to
+451
| deploymentIDForCurrentCmd, _, err := getDeploymentIDForCurrentCommandVar(houstonClient, wsID, deploymentID, deploymentID == "") | ||
| if err != nil { | ||
| return err | ||
| } | ||
| deploymentID = deploymentIDForCurrentCmd | ||
| if deploymentID == "" { | ||
| return errInvalidDeploymentID | ||
| } |
There was a problem hiding this comment.
Suggested change
| deploymentIDForCurrentCmd, _, err := getDeploymentIDForCurrentCommandVar(houstonClient, wsID, deploymentID, deploymentID == "") | |
| if err != nil { | |
| return err | |
| } | |
| deploymentID = deploymentIDForCurrentCmd | |
| if deploymentID == "" { | |
| return errInvalidDeploymentID | |
| } | |
| deploymentID, _, err := getDeploymentIDForCurrentCommandVar(houstonClient, wsID, deploymentID, deploymentID == "") | |
| if err != nil { | |
| return err | |
| } | |
| if deploymentID == "" { | |
| return errInvalidDeploymentID | |
| } |
nit: simplifying the logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the support for --image-name flag in the astro deploy command. Internally, it will call the updateDeploymentImage API. No image will be pushed to the registry. The command will be like this -
astro deploy --image-name IMAGE_URL --runtime-version IMAGE_RUNTIME_VERSION
🎟 Issue(s)
Related https://github.com/astronomer/issues/issues/6828
🧪 Functional Testing
Tested locally
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft